Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #634: add tests to verify that empty JSON Object as projection includes whole doc #642

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

tatu-at-datastax
Copy link
Contributor

What this PR does:

Adds tests to verify behavior of { } as "projection": it should include the whole document (as opposed to including nothing).

Which issue(s) this PR fixes:
Fixes #634

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@tatu-at-datastax tatu-at-datastax self-assigned this Nov 14, 2023
@tatu-at-datastax tatu-at-datastax requested a review from a team as a code owner November 14, 2023 18:47
@tatu-at-datastax
Copy link
Contributor Author

One CI job stuck, will close + re-open

@tatu-at-datastax tatu-at-datastax merged commit e810a25 into main Nov 15, 2023
5 of 6 checks passed
@tatu-at-datastax tatu-at-datastax deleted the tatu/634-empty-projection-tests branch November 15, 2023 16:05
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants